FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.9

Threshold is low

Effort is max

Summary

ClassesBugsErrorsMissing Classes
2394600

org.apache.velocity.app.event.implement.IncludeNotFound

BugCategoryDetailsLinePriority
IncludeNotFound.context not initialized in constructorSTYLEUWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTORNot availableLow

org.apache.velocity.runtime.RuntimeInstance

BugCategoryDetailsLinePriority
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.configuration; locked 58% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1636Medium
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.log; locked 82% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1622Medium
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.parserPool; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1213Medium
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.provideEvaluateScope; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1414Medium
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.eventCartridge; locked 85% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1814Low
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.introspector; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1804Low
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.resourceManager; locked 50% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1610Low
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.runtimeDirectivesShared; locked 66% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1002Low
Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.uberSpect; locked 90% of timeMT_CORRECTNESSIS2_INCONSISTENT_SYNC1848Low
Redundant nullcheck of nodeTree, which is known to be non-null in org.apache.velocity.runtime.RuntimeInstance.evaluate(Context, Writer, String, Reader)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE1323Low
Exception is caught when Exception is not thrown in org.apache.velocity.runtime.RuntimeInstance.loadDirective(String)STYLEREC_CATCH_EXCEPTION1056Low

org.apache.velocity.runtime.directive.Block$Reference

BugCategoryDetailsLinePriority
org.apache.velocity.runtime.directive.Block$Reference.toString() may return nullBAD_PRACTICENP_TOSTRING_COULD_RETURN_NULL181Medium

org.apache.velocity.runtime.directive.VelocimacroProxy

BugCategoryDetailsLinePriority
Dead store to templateName in org.apache.velocity.runtime.directive.VelocimacroProxy.checkDepth(InternalContextAdapter)STYLEDLS_DEAD_LOCAL_STORE277Medium

org.apache.velocity.runtime.log.HoldingLogChute

BugCategoryDetailsLinePriority
Method org.apache.velocity.runtime.log.HoldingLogChute.log(int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR60Medium
Method org.apache.velocity.runtime.log.HoldingLogChute.log(int, String, Throwable) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR78Medium

org.apache.velocity.runtime.parser.JJTParserState

BugCategoryDetailsLinePriority
Method org.apache.velocity.runtime.parser.JJTParserState.openNodeScope(Node) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR77Medium

org.apache.velocity.runtime.parser.Parser

BugCategoryDetailsLinePriority
Switch statement found in org.apache.velocity.runtime.parser.Parser.Escape() where default case is missingSTYLESF_SWITCH_NO_DEFAULT499-506Low
Switch statement found in org.apache.velocity.runtime.parser.Parser.jj_rescan_token() where default case is missingSTYLESF_SWITCH_NO_DEFAULT4026-4029Low

org.apache.velocity.runtime.parser.ParserTokenManager

BugCategoryDetailsLinePriority
Switch statement found in org.apache.velocity.runtime.parser.ParserTokenManager.getNextToken() where default case is missingSTYLESF_SWITCH_NO_DEFAULT5566-5570Low

org.apache.velocity.runtime.parser.node.ASTComparisonNode

BugCategoryDetailsLinePriority
org.apache.velocity.runtime.parser.node.ASTComparisonNode.compareNumbers(Object, Object) has Boolean return type and returns explicit nullBAD_PRACTICENP_BOOLEAN_RETURN_NULL122Medium
Private method org.apache.velocity.runtime.parser.node.ASTComparisonNode.getLiteral(boolean) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD143Low

org.apache.velocity.runtime.parser.node.ASTEQNode

BugCategoryDetailsLinePriority
Comparison of String objects using == or != in org.apache.velocity.runtime.parser.node.ASTEQNode.compareNonNumber(Object, Object) BAD_PRACTICEES_COMPARING_STRINGS_WITH_EQ75Low

org.apache.velocity.runtime.parser.node.ASTIndex

BugCategoryDetailsLinePriority
Method org.apache.velocity.runtime.parser.node.ASTIndex.adjMinusIndexArg(Object, Object, InternalContextAdapter, SimpleNode) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR118Medium
Unread field: org.apache.velocity.runtime.parser.node.ASTIndex.methodName; should this field be static?PERFORMANCESS_SHOULD_BE_STATIC39Medium

org.apache.velocity.runtime.parser.node.ASTIntegerRange

BugCategoryDetailsLinePriority
Method org.apache.velocity.runtime.parser.node.ASTIntegerRange.value(InternalContextAdapter) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR140Medium

org.apache.velocity.runtime.parser.node.MathUtils

BugCategoryDetailsLinePriority
Method org.apache.velocity.runtime.parser.node.MathUtils.add(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 303] insteadPERFORMANCEDM_FP_NUMBER_CTOR303Low
Method org.apache.velocity.runtime.parser.node.MathUtils.add(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 301] insteadPERFORMANCEDM_FP_NUMBER_CTOR301Low
Method org.apache.velocity.runtime.parser.node.MathUtils.divide(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 404] insteadPERFORMANCEDM_FP_NUMBER_CTOR404Low
Method org.apache.velocity.runtime.parser.node.MathUtils.divide(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 402] insteadPERFORMANCEDM_FP_NUMBER_CTOR402Low
Method org.apache.velocity.runtime.parser.node.MathUtils.modulo(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 431] insteadPERFORMANCEDM_FP_NUMBER_CTOR431Low
Method org.apache.velocity.runtime.parser.node.MathUtils.modulo(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 429] insteadPERFORMANCEDM_FP_NUMBER_CTOR429Low
Method org.apache.velocity.runtime.parser.node.MathUtils.multiply(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 371] insteadPERFORMANCEDM_FP_NUMBER_CTOR371Low
Method org.apache.velocity.runtime.parser.node.MathUtils.multiply(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 369] insteadPERFORMANCEDM_FP_NUMBER_CTOR369Low
Method org.apache.velocity.runtime.parser.node.MathUtils.subtract(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 337] insteadPERFORMANCEDM_FP_NUMBER_CTOR337Low
Method org.apache.velocity.runtime.parser.node.MathUtils.subtract(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 335] insteadPERFORMANCEDM_FP_NUMBER_CTOR335Low
Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) insteadPERFORMANCEDM_NUMBER_CTOR188Medium
Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR212Medium
Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Long(long) constructor; use Long.valueOf(long) insteadPERFORMANCEDM_NUMBER_CTOR218Medium
Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Short(short) constructor; use Short.valueOf(short) insteadPERFORMANCEDM_NUMBER_CTOR200Medium

org.apache.velocity.runtime.resource.ResourceFactory

BugCategoryDetailsLinePriority
Switch statement found in org.apache.velocity.runtime.resource.ResourceFactory.getResource(String, int) where default case is missingSTYLESF_SWITCH_NO_DEFAULT50-54Low

org.apache.velocity.runtime.resource.loader.DataSourceResourceLoader

BugCategoryDetailsLinePriority

org.apache.velocity.runtime.resource.loader.ResourceLoaderFactory

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.velocity.runtime.resource.loader.ResourceLoaderFactory.getLoader(RuntimeServices, String)STYLEREC_CATCH_EXCEPTION54Low

org.apache.velocity.runtime.resource.loader.URLResourceLoader

BugCategoryDetailsLinePriority
Method org.apache.velocity.runtime.resource.loader.URLResourceLoader.tryToSetTimeout(URLConnection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR217Medium

org.apache.velocity.util.StringUtils

BugCategoryDetailsLinePriority
Exception is caught when Exception is not thrown in org.apache.velocity.util.StringUtils.fileContentsToString(String)STYLEREC_CATCH_EXCEPTION340Low
org.apache.velocity.util.StringUtils.fileContentsToString(String) ignores result of java.io.FileReader.read(char[])BAD_PRACTICERR_NOT_CHECKED337Low