The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is max
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| IncludeNotFound.context not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.configuration; locked 58% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1636 | Medium |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.log; locked 82% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1622 | Medium |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.parserPool; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1213 | Medium |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.provideEvaluateScope; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1414 | Medium |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.eventCartridge; locked 85% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1814 | Low |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.introspector; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1804 | Low |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.resourceManager; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1610 | Low |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.runtimeDirectivesShared; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1002 | Low |
| Inconsistent synchronization of org.apache.velocity.runtime.RuntimeInstance.uberSpect; locked 90% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1848 | Low |
| Redundant nullcheck of nodeTree, which is known to be non-null in org.apache.velocity.runtime.RuntimeInstance.evaluate(Context, Writer, String, Reader) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1323 | Low |
| Exception is caught when Exception is not thrown in org.apache.velocity.runtime.RuntimeInstance.loadDirective(String) | STYLE | REC_CATCH_EXCEPTION | 1056 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.velocity.runtime.directive.Block$Reference.toString() may return null | BAD_PRACTICE | NP_TOSTRING_COULD_RETURN_NULL | 181 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to templateName in org.apache.velocity.runtime.directive.VelocimacroProxy.checkDepth(InternalContextAdapter) | STYLE | DLS_DEAD_LOCAL_STORE | 277 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.velocity.runtime.log.HoldingLogChute.log(int, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 60 | Medium |
| Method org.apache.velocity.runtime.log.HoldingLogChute.log(int, String, Throwable) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.velocity.runtime.parser.JJTParserState.openNodeScope(Node) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.apache.velocity.runtime.parser.Parser.Escape() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 499-506 | Low |
| Switch statement found in org.apache.velocity.runtime.parser.Parser.jj_rescan_token() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 4026-4029 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.apache.velocity.runtime.parser.ParserTokenManager.getNextToken() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 5566-5570 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.velocity.runtime.parser.node.ASTComparisonNode.compareNumbers(Object, Object) has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 122 | Medium |
| Private method org.apache.velocity.runtime.parser.node.ASTComparisonNode.getLiteral(boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 143 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.velocity.runtime.parser.node.ASTEQNode.compareNonNumber(Object, Object) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 75 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.velocity.runtime.parser.node.ASTIndex.adjMinusIndexArg(Object, Object, InternalContextAdapter, SimpleNode) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 118 | Medium |
| Unread field: org.apache.velocity.runtime.parser.node.ASTIndex.methodName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.velocity.runtime.parser.node.ASTIntegerRange.value(InternalContextAdapter) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 140 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.velocity.runtime.parser.node.MathUtils.add(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 303] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 303 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.add(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 301] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 301 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.divide(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 404] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 404 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.divide(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 402] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 402 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.modulo(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 431] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 431 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.modulo(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 429] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 429 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.multiply(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 371] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 371 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.multiply(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 369] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 369 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.subtract(Number, Number) invokes inefficient Double.valueOf(double) constructor; use MathUtils.java:[line 337] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 337 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.subtract(Number, Number) invokes inefficient Float.valueOf(float) constructor; use MathUtils.java:[line 335] instead | PERFORMANCE | DM_FP_NUMBER_CTOR | 335 | Low |
| Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead | PERFORMANCE | DM_NUMBER_CTOR | 188 | Medium |
| Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 212 | Medium |
| Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 218 | Medium |
| Method org.apache.velocity.runtime.parser.node.MathUtils.wrapPrimitive(long, Class) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead | PERFORMANCE | DM_NUMBER_CTOR | 200 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in org.apache.velocity.runtime.resource.ResourceFactory.getResource(String, int) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 50-54 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.velocity.runtime.resource.loader.ResourceLoaderFactory.getLoader(RuntimeServices, String) | STYLE | REC_CATCH_EXCEPTION | 54 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.velocity.runtime.resource.loader.URLResourceLoader.tryToSetTimeout(URLConnection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.velocity.util.StringUtils.fileContentsToString(String) | STYLE | REC_CATCH_EXCEPTION | 340 | Low |
| org.apache.velocity.util.StringUtils.fileContentsToString(String) ignores result of java.io.FileReader.read(char[]) | BAD_PRACTICE | RR_NOT_CHECKED | 337 | Low |